Add an endurance soak for signed requests - #112
Open
beetlebugorg wants to merge 1 commit into
Open
Conversation
- Generate signed /dims3/, /dims4/, and /dims5/ requests from a seed. - Compare each response against the result the generator requires. - Build a corpus of real files from govdocs1 and Wikimedia Commons. - Run the production image under a CPU and memory limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test/endurance/drives signed/dims3/,/dims4/, and/dims5/requests at the production image for hours, and compares each response against the result the request requires. A seeded generator picks the endpoint, the source, a chain of one to six operations, every argument, the query, and one of fifteen mutations applied after signing. The same seed sends the same requests. Three modes share the client:soakruns the production image,asanruns a sanitizer build, andvalgrindaccounts for leaks.corpus.shbuilds the sources. The bulk is govdocs1 archives from digitalcorpora, a thousand real files each, most of them not images: PDF, PostScript, Office, HTML, and text. A Wikimedia Commons top-up adds PNG, TIFF, WebP, SVG, and animated GIF. Local re-encodings and a generated hostile set complete it. Each file is classified by a decode through the toolchain ImageMagick, read from a stream the way the module reads a fetched source, so the manifest holds the expected result for each one.The corpus and every run artifact are ignored by git.
make testdoes not run any of this.Why
The golden files record what the module returns for a fixed set of requests. Nothing measured what it does over millions of varied ones.
A three hour run sent 266,334 requests. No crash, no OOM kill, and no tampered request served. It reported 386 failures, 0.145%, in four classes. The largest is a crop rectangle outside the image, which answers 500.
Verify
The report names the seed and the failure counts. A pass has zero crashes, zero OOM kills, and zero tampered requests served. The exit status is zero.
make teststill passes, 271 of 271.