Repository navigation
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Python's GIL around
UIApplicationMain, restoring the thread state on return or an Objective-C exception. Advertisesys._ios_app_main_releases_gil = Truebefore importing app code so Rubicon can safely disable nesting. Refs beeware/rubicon-objc#846.The complete fix requires this PR and beeware/rubicon-objc#847. Either component can be upgraded independently; only updating both disables nesting. No Toga or application code change is needed, but generated native launchers must be updated and rebuilt.
All four old/new Rubicon and launcher combinations passed the included simulator checks for nesting and prompt worker callbacks, as did a smoke test with unmodified Toga 0.5.7. Pre-commit passes; physical iPad trackpad validation remains outstanding.
PR Checklist:
Assisted-by: OpenAI Codex