fix: slug extra user names into k8s secret names - #133
Merged
Conversation
Contributor
Author
|
🤖 Renaming the declared user to This PR is the other half: without it, a role name that can't be a k8s name takes that replica's restores down silently until someone reads the operator log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers don't derive this name: the Secret is labelled
pgro.bes.au/component=extra-user-creds+pgro.bes.au/replica=<name>, and carries the unslugged role underusername.An underscore in a role name (
tupaia_read) made an invalid Secret name, andensure_extra_user_secretsfailing with?stopped the replica reconcile before it scheduled a restore.tupaia_readlands on<replica>-user-tupaia-read-credsRegression from #129 (v0.4.18).