Skip to content

fix: slug extra user names into k8s secret names - #133

Merged
passcod merged 4 commits into
mainfrom
fix/extra-user-secret-name
Aug 28, 2026
Merged

fix: slug extra user names into k8s secret names#133
passcod merged 4 commits into
mainfrom
fix/extra-user-secret-name

Conversation

@dannash100

@dannash100 dannash100 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Consumers don't derive this name: the Secret is labelled pgro.bes.au/component=extra-user-creds + pgro.bes.au/replica=<name>, and carries the unslugged role under username.

An underscore in a role name (tupaia_read) made an invalid Secret name, and ensure_extra_user_secrets failing with ? stopped the replica reconcile before it scheduled a restore.

  • slug the username, so tupaia_read lands on <replica>-user-tupaia-read-creds
  • two roles that slug alike would share a Secret; declaring both is a config error we accept
  • no migration, the Secret was never created on any affected replica

Regression from #129 (v0.4.18).

@dannash100

Copy link
Copy Markdown
Contributor Author

🤖 Renaming the declared user to tupaia-read in Canopy unblocks the three stale replicas within the hour, no release or image bump needed. Tupaia's connection config would have to change at the same time.

This PR is the other half: without it, a role name that can't be a k8s name takes that replica's restores down silently until someone reads the operator log.

@passcod
passcod merged commit 44829a5 into main Aug 28, 2026
23 checks passed
@passcod
passcod deleted the fix/extra-user-secret-name branch August 28, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants