Repository navigation
agent: CI scans release binaries for test-seam names - #161
Merged
Merged
Conversation
The authority on "no test seam ships" is now the artifact itself: CI's `build (release)` job runs `mise check:release-seams`, which greps every top-level release binary for the BEYOND_AI_AGENT_TEST_ prefix and fails on any hit. tests/release_seams.rs stays as the fast source-level warning and pins the scanner (it must fail on the debug build and on a concat!-built name). Split out of #159; its restore-window half is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JimHGjsfk2Ktm5GxyZJKKk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #159: only the release-binary seam scan.
build (release)job runsmise check:release-seamsaftermise build:rs:release. It greps every top-level release binary for theBEYOND_AI_AGENT_TEST_prefix and fails on any hit, so a test seam can't ship however the source spells it (concat!, a//inside a string literal).tests/release_seams.rsremains the fast source-level warning and pins the scanner: it must fail on the debug build (which carries the seams) and on aconcat!-assembled name, and pass a clean file.#159's audit verified this half correct. The restore-window half of #159 is dropped (narrow MCP Events webhook edge case; current behaviour on main is acceptable).
🤖 Generated with Claude Code
https://claude.ai/code/session_01JimHGjsfk2Ktm5GxyZJKKk