Skip to content

Improve per-session SFTP and Hosts management - #120

Merged
bifrost0x merged 3 commits into
mainfrom
dev/discussions-116-119-followup
Aug 20, 2026
Merged

Improve per-session SFTP and Hosts management#120
bifrost0x merged 3 commits into
mainfrom
dev/discussions-116-119-followup

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • scope embedded SFTP capability and visibility to each active SSH session
  • keep incompatible sessions closed while preserving a manual fallback for inconclusive probes
  • keep Hosts controls fixed, focus search on open, and add Collapse all

Behavior

  • switching from Linux to a Cisco-style session closes embedded SFTP without retargeting the panel
  • switching back restores the Linux session's own open or closed preference
  • all eligible desktop sessions are capability-probed regardless of session count
  • disconnects and layout changes cancel pending probe retries without misclassifying the session
  • known-unavailable sessions keep the embedded SFTP control disabled
  • search, Collapse all, and Create saved connection remain visible while only the host list scrolls

Tests

  • npm run test:js (228 passed)
  • npm run lint:js
  • npm run vendor:check
  • python -m pytest tests -q (1605 passed, 33 skipped)
  • affected Python UI contracts (37 passed)
  • relevant Playwright specs (25 passed)
  • final focused Playwright regressions (3 passed)

@bifrost0x
bifrost0x marked this pull request as ready for review August 20, 2026 07:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e44904c82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/session-workspace.js
@bifrost0x bifrost0x self-assigned this Aug 20, 2026
@bifrost0x bifrost0x added the bug Something isn't working label Aug 20, 2026
@bifrost0x
bifrost0x merged commit 248c974 into main Aug 20, 2026
15 of 16 checks passed
@bifrost0x
bifrost0x deleted the dev/discussions-116-119-followup branch August 20, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant