Repository navigation
build: require Node >= 22 and build with Node 24 - #26
Merged
Merged
Conversation
Add an `engines` floor of Node >= 22 to package.json and mirror it into package-lock.json, and bump @types/node to ^24.13.3 so the typings match the runtime the plugin is built with. Move CI onto Node 24 (was Node 20). Raise the Debian Build-Depends floor to nodejs (>= 22) and install Node 24 from NodeSource when building the package.
imdt-claudiop
approved these changes
Sep 14, 2026
imdt-claudiop
left a comment
Contributor
There was a problem hiding this comment.
Approved.
Same shape as bigbluebutton/bbb-plugin-picture-in-picture#43, which is already merged: Node 24 across the workflows, nodejs (>= 22) in debian/control, and engines.node >= 22 plus @types/node ^24.13.3 in package.json.
Checked out this branch and ran it on Node 24.9.0:
npm installclean, and package-lock.json shows no drift afterwardsnpx tscpasses (same command as the ts-code-compilation check)npm run lintpasses (same command as the ts-code-validation check)npm run build-bundleproducesdist/BbbPluginSessionShare.js
I also scanned the rest of the tree for leftover references to the older Node line, and there are none.
* build: declare @types/node only in devDependencies @types/node was listed in both dependencies and devDependencies, and the two had drifted apart before they were aligned on ^24.13.3. It supplies build-time typings only, so keep the devDependencies entry and drop the duplicate. npm already resolved it as a dev-only package, so installs are unaffected; this just makes package.json say what npm was already doing. * build: resolve npm audit advisories (#28) Run npm audit fix, then take the two major upgrades it could not apply on its own: copy-webpack-plugin 12 -> 14 and webpack-dev-server 4 -> 6. Between them these clear the shell-quote and websocket-driver criticals and the serialize-javascript, sockjs and uuid advisories. Everything changed here is build tooling; none of it ships in the bundle. webpack-dev-server 6 was verified beyond a successful build by starting the dev server and confirming the custom devServer.app route for /manifest.json still answers 200. Pin watch back to ^0.13.0, the version the other repos already use. Its 1.x line pulls exec-sh and a prototype-pollution advisory in merge, and npm's own resolution for those advisories is 0.13.0. It only backs the lint:watch helper script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves this plugin onto Node 24 and declares a supported-Node floor.
package.jsongains anenginesfield:"node": ">=22", mirrored intopackage-lock.jsonso the two agree.@types/nodebumped to^24.13.3so the typings match the runtime the pluginis actually built with. It was declared twice, at
^20.3.1and^20.4.4;both are aligned here.
ts-code-compilation.yml—node-version: 20.x->24.xts-code-validation.yml—node-version: 20.x->24.xpublish-tag.yml—node-version: '20'->'24'build-plugin-deb-package.yml— NodeSourcesetup_20.x->setup_24.xdebian/controlBuild-Depends raised fromnodejs (>= 18)tonodejs (>= 22).One new lockfile entry
undici-typesappears as a new entry. It is a genuine dependency of@types/node24 (the 20.x line did not have it), not incidental churn. It isthe only package added anywhere in this change.
Why the Debian floor is 22 while the build pin is 24
Build-Dependsis a minimum constraint, not a pin, so it is kept in step withthe
enginesfloor — the package stays buildable on a Node 22 builder. Theversion actually used to build is pinned separately, and that is 24 via the
NodeSource line in the workflow.
Testing
Against Node 24.20.0 / npm 11.19.0, running the same chain CI does:
npm ci— PASSnpx tsc— PASSnpm run lint— PASSnpm run build-bundle— PASSWorth flagging for the future: TypeScript resolves to 5.2.2 here, the lowest of
any plugin in the set.
@types/node24 needs 5.2 or newer forSymbol.disposeand
Disposable, so this repo passes with no margin at all. A sibling repopinned at 5.1.3 failed
tscoutright with ~55 errors inside@types/node's owndeclaration files and had to have TypeScript moved forward. Nothing to do here
today — the
^5.1.6spec already allows newer — but this is the repo mostlikely to be tripped by the next typings bump.
Notes for review
Aside from
undici-types, the lock diff is confined to theenginesblock andthe
@types/noderesolution.lockfileVersionis unchanged.