Repository navigation
build: declare @types/node only in devDependencies - #27
Merged
Merged
Conversation
@types/node was listed in both dependencies and devDependencies, and the two had drifted apart before they were aligned on ^24.13.3. It supplies build-time typings only, so keep the devDependencies entry and drop the duplicate. npm already resolved it as a dev-only package, so installs are unaffected; this just makes package.json say what npm was already doing.
imdt-claudiop
approved these changes
Sep 14, 2026
imdt-claudiop
left a comment
imdt-claudiop
left a comment
Contributor
There was a problem hiding this comment.
Approved.
Identical in shape to bigbluebutton/bbb-plugin-picture-in-picture#44, which is already merged: @types/node dropped from dependencies, kept in devDependencies, with the matching package-lock.json root entry removed. Nothing else changes.
Verified on Node 24.9.0 against this branch: npm install clean with no lockfile drift, npx tsc passes, npm run lint passes, and npm run build-bundle produces dist/BbbPluginSessionShare.js.
Type resolution is unaffected, since devDependencies still provides @types/node ^24.13.3 and that is what the compiler picks up.
Run npm audit fix, then take the two major upgrades it could not apply on its own: copy-webpack-plugin 12 -> 14 and webpack-dev-server 4 -> 6. Between them these clear the shell-quote and websocket-driver criticals and the serialize-javascript, sockjs and uuid advisories. Everything changed here is build tooling; none of it ships in the bundle. webpack-dev-server 6 was verified beyond a successful build by starting the dev server and confirming the custom devServer.app route for /manifest.json still answers 200. Pin watch back to ^0.13.0, the version the other repos already use. Its 1.x line pulls exec-sh and a prototype-pollution advisory in merge, and npm's own resolution for those advisories is 0.13.0. It only backs the lint:watch helper script.
antobinary
added a commit
that referenced
this pull request
Sep 29, 2026
* build: require Node >= 22 and build with Node 24 Add an `engines` floor of Node >= 22 to package.json and mirror it into package-lock.json, and bump @types/node to ^24.13.3 so the typings match the runtime the plugin is built with. Move CI onto Node 24 (was Node 20). Raise the Debian Build-Depends floor to nodejs (>= 22) and install Node 24 from NodeSource when building the package. * build: declare @types/node only in devDependencies (#27) * build: declare @types/node only in devDependencies @types/node was listed in both dependencies and devDependencies, and the two had drifted apart before they were aligned on ^24.13.3. It supplies build-time typings only, so keep the devDependencies entry and drop the duplicate. npm already resolved it as a dev-only package, so installs are unaffected; this just makes package.json say what npm was already doing. * build: resolve npm audit advisories (#28) Run npm audit fix, then take the two major upgrades it could not apply on its own: copy-webpack-plugin 12 -> 14 and webpack-dev-server 4 -> 6. Between them these clear the shell-quote and websocket-driver criticals and the serialize-javascript, sockjs and uuid advisories. Everything changed here is build tooling; none of it ships in the bundle. webpack-dev-server 6 was verified beyond a successful build by starting the dev server and confirming the custom devServer.app route for /manifest.json still answers 200. Pin watch back to ^0.13.0, the version the other repos already use. Its 1.x line pulls exec-sh and a prototype-pollution advisory in merge, and npm's own resolution for those advisories is 0.13.0. It only backs the lint:watch helper script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops the duplicate
@types/nodeentry fromdependencies, keeping the one indevDependencies.Why
@types/nodewas declared in both sections, and the two had drifted apart(
^20.3.1against^20.4.4) before they were aligned in the Node 24 PR. Itsupplies build-time typings only — nothing under
src/imports it at runtimeand it contributes nothing to the emitted bundle.
Neither CI nor
debian/rulesinstalls with--omit=devorNODE_ENV=production, so the typings remain present wherever the bundle isbuilt. npm already resolved it as a dev-only package, so installs are
unaffected; this just makes
package.jsonsay what npm was already doing.Testing
Against Node 24.20.0:
npm ci— PASSnpx tsc— PASSnpm run lint— PASSnpm run build-bundle— PASSNotes for review
One line out of
package.jsonplus the matching lock line. Depends on the Node24 PR and should merge after it.