Repository navigation
fix(webhooks): log the event representation the hook subscribed to - #77
Merged
prlanzarin merged 1 commit intoSep 14, 2026
Merged
Conversation
The callback emitter receives either a mapped event or a raw one,
depending on the hook's getRaw setting, but it has no way of telling
them apart. It runs every event through simplifiedEvent(), which reads
data.id and data.event.ts -- paths that do not exist in a raw BBB
message. Callbacks for getRaw hooks therefore log
"event: { name: undefined, timestamp: undefined }", hiding which event
was actually delivered.
Forward the hook's getRaw flag to the emitter and pick the logged
payload accordingly: raw hooks log the untouched message under rawEvent
and an empty event, mapped hooks keep the simplified string under event
and an empty rawEvent. Both keys are always present so the log shape
stays stable for parsers. The failure log gets the same treatment, since
it suffers from the same undefined fields.
Detecting the event format inside the emitter by probing for envelope or
data keys was considered and discarded: the hook already carries the
answer, and guessing would silently misclassify future event shapes.
prlanzarin
self-requested a review
September 14, 2026 17:23
prlanzarin
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The callback emitter receives either a mapped event or a raw one, depending on the hook's getRaw setting, but it has no way of telling them apart. It runs every event through simplifiedEvent(), which reads data.id and data.event.ts -- paths that do not exist in a raw BBB message. Callbacks for getRaw hooks therefore log
"event: { name: undefined, timestamp: undefined }", hiding which event was actually delivered.
Forward the hook's getRaw flag to the emitter and pick the logged payload accordingly: raw hooks log the untouched message under rawEvent and an empty event, mapped hooks keep the simplified string under event and an empty rawEvent. Both keys are always present so the log shape stays stable for parsers. The failure log gets the same treatment, since it suffers from the same undefined fields.
Detecting the event format inside the emitter by probing for envelope or data keys was considered and discarded: the hook already carries the answer, and guessing would silently misclassify future event shapes.