decide for kicking depending on distance of seen robots#1007
Merged
Conversation
Draft
jaagut
marked this pull request as ready for review
July 12, 2026 04:14
jaagut
reviewed
Jul 12, 2026
| self.closest_robot_infront_dist = dist_to_robot | ||
| else: | ||
| if dist_to_robot < self.closest_robot_behind_dist: | ||
| self.closest_robot_behind_dist = dist_to_robot |
Member
There was a problem hiding this comment.
Is infront and behind the correct term here? The other robot is not infront or behind relative to our own player (it's rotation is not relevant here).
Contributor
Co-authored-by: Jan Gutsche <34797331+jaagut@users.noreply.github.com>
MegaIng
approved these changes
Jul 12, 2026
MegaIng
self-requested a review
July 12, 2026 07:30
Member
|
Tests don't pass for some reason |
Member
|
@copilot fix the formatting by running pixi run -e format format |
Contributor
I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dribble if there are other robots close, since kicking tools to long
Proposed changes
Related issues
Checklist
pixi run build