Test suite: forward the app's native CodePush logs into the test log - #28
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the mocha-based integration test harness by streaming the app’s native CodePush logs (iOS Simulator logs / Android logcat) into the test run output, improving diagnosability in CI and local runs.
Changes:
- Add a native log forwarding subprocess (xcrun simctl log stream on iOS, adb logcat on Android).
- Parse iOS
log stream --style ndjsonentries and prefix forwarded lines with[NATIVE]in the test output. - Start forwarding at test runtime and stop it at the end of the suite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+732
to
+738
| // Failing to stream logs must never fail the run, this is diagnostics only. The handler | ||
| // is also required: an unhandled "error" event on a child process throws. | ||
| logProcess.on("error", (error: Error) => { | ||
| console.log(`[NATIVE] Could not stream native logs: ${error.message}`); | ||
| }); | ||
|
|
||
| nativeLogProcess = logProcess; |
Collaborator
Author
There was a problem hiding this comment.
ofalvai
force-pushed
the
push-slkwnlqmpunm
branch
from
August 11, 2026 11:13
c8b9438 to
b56b50b
Compare
ofalvai
marked this pull request as ready for review
August 11, 2026 11:48
miklosboros
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had this need/idea while working on #27