Skip to content

Feature/optimize logging repr #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gthelen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/optimize logging repr #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ea0161
Optimize RevRange.__repr__ to avoid expensive git calls
gthelen Jul 25, 2026
659f904
Optimize WorkerPool.enqueue logging
gthelen Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions git-brisect
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ class RevRange:
return cls(exclude=exclude, include=include[0])

def __repr__(self):
return "RevRange([%s %s] %d commits)" % (
describe(self.include), " ".join("^" + describe(e) for e in self.exclude), len(self.commits()))
exclude_str = f" {' '.join('^' + e for e in sorted(self.exclude))}" if self.exclude else ""
return f"RevRange({self.include}{exclude_str})"

def _get_commits(self):
if self._commits is not None:
Expand Down Expand Up @@ -215,7 +215,7 @@ class WorkerPool:
def enqueue(self, rev):
with self._cond:
self._in_q.append(rev_parse(rev))
logger.debug(f"Enqueued {describe(rev)}, new queue depth {len(self._in_q)}")
logger.debug("Enqueued %s, new queue depth %d", rev, len(self._in_q))
self._cond.notify_all()

def num_pending(self):
Expand Down
7 changes: 7 additions & 0 deletions git_brisect_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,13 @@ def test_dot_dot(self):
with self.assertRaises(git_brisect.BadRangeError):
_ = git_brisect.RevRange.from_string("foo..bar baz")

def test_repr(self):
r = git_brisect.RevRange(exclude=["bar", "baz"], include="foo")
self.assertEqual(repr(r), "RevRange(foo ^bar ^baz)")

r = git_brisect.RevRange(exclude=[], include="foo")
self.assertEqual(repr(r), "RevRange(foo)")


@dataclasses.dataclass
class DagNode:
Expand Down