Repository navigation
[buzz-app] Allow reviewed Git-to-URL plugin updates - #3355
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Helen Tian <htian@squareup.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Helen Tian <htian@squareup.com>
htian-dev
marked this pull request as ready for review
November 12, 2026 04:44
kazemek21
approved these changes
Nov 12, 2026
kazemek21
left a comment
kazemek21
left a comment
Contributor
There was a problem hiding this comment.
Kyle reviewed this PR and the Nexus review-tracker notes and approved with no comments.
Posted by Codex (gpt-6.1-sol) on behalf of kylez.
Resolve against #3091: a URL install still updates a Git-installed plugin in place after review, and only folder or unknown sources get the pre-download "Already installed" refusal. Tests and docs that used a Git install to trigger the refusal now use a folder install. Refs AGNTOPS-791 Co-authored-by: Hertz <c6741012416ef5c49a865db79682113385c5fb998e8c890234fb442b59e22748@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Joah Gerstenberg <joah@squareup.com>
ljknight
added a commit
to ljknight/buzz-app
that referenced
this pull request
Nov 12, 2026
Signed-off-by: Laura Knight <lauraknight@squareup.com> * origin/main: fix(goose): propagate ACP work cancellation to plugin tools (block#3351) Keep Solo source selection when opening a channel (block#3356) fix(desktop): sign a channel-less deletion of one reaction (block#3288) AIDA-2426: Set a default User-Agent for plugins (block#2697) fix(plugins): explain Git import refs (block#3314) fix(codex): allow the runtime CLI credential provider (block#3375) [buzz-app] Allow reviewed Git-to-URL plugin updates (block#3355)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Some plugins were installed from Git, but their newer versions are now offered as downloads. Clicking Update or Reinstall fails because Buzz treats this as a different install source. Users have to delete the plugin and install it again. If the plugin is Marketplace itself, deleting it also removes the page used to reinstall it.
Cause: The update screen blocks this switch, even though the installer can already handle it.
Fix: Let users review the change and click Update. Buzz replaces the plugin without deleting it first and remembers the download URL for future updates. It keeps the plugin enabled or disabled as before, and the same publisher and signature checks still apply.
The screenshots use an example plugin. Before: the update fails. After: users can review the source change and continue.
Folder and unknown sources: A URL install over a plugin installed from a folder or an unknown source is still refused before anything downloads, with Open plugin to remove it first (#3091). Only Git installations update in place.
Validation: Besides the unit and browser specs, the native installer path was exercised against a copy of a real profile whose Marketplace was installed from Git: installing the published Marketplace artifact from its URL replaced the Git source with the URL, kept the plugin enabled, left every other plugin unchanged, and Roll back restored the Git build and source.
Refs AGNTOPS-791
buzz-review-completed