Skip to content

Keep channel day dividers sticky#1420

Merged
wesbillman merged 3 commits into
mainfrom
kennylopez-sticky-day-dividers
Jul 1, 2026
Merged

Keep channel day dividers sticky#1420
wesbillman merged 3 commits into
mainfrom
kennylopez-sticky-day-dividers

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

Summary

  • Restore sticky day labels in channel timelines while letting the divider line scroll with the message group.
  • Keep day pills above the timeline content but behind the composer/header chrome.
  • Remove the pill shadow while preserving the solid background.

Snapshot

Sticky channel day dividers

Checks

  • git diff --check HEAD
  • pnpm --dir desktop check
  • pnpm --dir desktop typecheck
  • Combined validation before splitting: pnpm --dir desktop test, pnpm --dir desktop build, focused Playwright smoke/integration suites

@klopez4212 klopez4212 marked this pull request as ready for review July 1, 2026 11:36
@klopez4212 klopez4212 requested a review from wesbillman July 1, 2026 11:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 392270b713

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/ui/ChannelPane.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af8c90dcc1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/DayDivider.tsx
@wesbillman wesbillman merged commit 8c38847 into main Jul 1, 2026
25 checks passed
@wesbillman wesbillman deleted the kennylopez-sticky-day-dividers branch July 1, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants