Skip to content

Tighten message density#1426

Merged
klopez4212 merged 10 commits into
mainfrom
kennylopez-message-density-polish
Jul 1, 2026
Merged

Tighten message density#1426
klopez4212 merged 10 commits into
mainfrom
kennylopez-message-density-polish

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Tightens top-level message row vertical padding for a denser chat timeline.
  • Shrinks reaction containers, keeps custom reaction emoji at 14px, and tunes native emoji/count vertical alignment.
  • Compacts the thread-summary participant stack and trims the thread-summary group spacing.
  • Updates the affected smoke E2E size assertions for the denser reaction and thread-summary avatar sizing.

Stack

Base: kennylopez-thread-summary-alignment
Head: kennylopez-message-density-polish

Snapshots

Compact message density with reactions and the thread-summary avatar stack.

message-density-thread-reactions

Validation

  • cd desktop && pnpm exec biome check src/features/messages/ui/MessageReactions.tsx src/features/messages/ui/MessageRow.tsx src/features/messages/ui/MessageThreadSummaryRow.tsx src/features/messages/ui/TimelineMessageList.tsx
  • cd desktop && pnpm exec biome check tests/e2e/custom-emoji.spec.ts tests/e2e/messaging.spec.ts
  • cd desktop && pnpm check:px-text
  • cd desktop && pnpm exec playwright test tests/e2e/custom-emoji.spec.ts tests/e2e/messaging.spec.ts --project=smoke
  • just desktop-screenshot --name message-density-thread-reactions --active-channel general --messages /private/tmp/sprout-density-messages.json --clip 220,170,900,430 --viewport 1280x720 --outdir /private/tmp/sprout-density-shots --wait 2500
  • just desktop-build via screenshot helper

Note: local pre-push hooks were not rerun for the follow-up push because this machine is still nearly out of disk space; an earlier full pre-push attempt failed in Rust/Tauri test compilation with No space left on device while writing generated artifacts. The targeted desktop checks above passed.

@klopez4212 klopez4212 requested a review from wesbillman July 1, 2026 11:43
@klopez4212 klopez4212 marked this pull request as ready for review July 1, 2026 11:43
@klopez4212

Copy link
Copy Markdown
Contributor Author

🤖 ## Snapshot

Compact message density with reactions and the thread-summary avatar stack.

message-density-thread-reactions

klopez4212 added a commit that referenced this pull request Jul 1, 2026
@klopez4212 klopez4212 marked this pull request as draft July 1, 2026 11:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab9fdfc0aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/MessageReactions.tsx
Comment thread desktop/src/features/messages/ui/MessageThreadSummaryRow.tsx
@klopez4212 klopez4212 marked this pull request as ready for review July 1, 2026 11:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ceef5f95b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/MessageRow.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a91cda6e7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/MessageRow.tsx
Base automatically changed from kennylopez-thread-summary-alignment to main July 1, 2026 14:49
…nsity-polish

# Conflicts:
#	desktop/src/features/messages/ui/MessageThreadSummaryRow.tsx
#	desktop/src/features/messages/ui/TimelineMessageList.tsx
#	desktop/tests/e2e/messaging.spec.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9547290be9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/shared/ui/markdown/CodeBlock.tsx Outdated
@klopez4212 klopez4212 merged commit 6a08a3f into main Jul 1, 2026
25 checks passed
@klopez4212 klopez4212 deleted the kennylopez-message-density-polish branch July 1, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants