Repository navigation
fix: exclude GitHub release metadata lookups from origin metrics - #443
Merged
Merged
Conversation
For private orgs, the github-releases transform gets release metadata from the GitHub API before it downloads the asset. That request used the artifact request context, so cachew.origin.requests counted it as origin traffic. The README says that GitHub metadata lookups are not counted. The metadata request now uses a context without the artifact request. The 429 backoff scope stays on the context. Co-authored-by: Chain <492cad42391b4a5c84d831885f468e6f1699c0a8c39241f1c002235ece37ee69@buzz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For private orgs, the github-releases transform gets release metadata from the GitHub API before it downloads the asset. That request used the artifact request context, so
cachew.origin.requestscounted it as origin traffic. Each private release miss counted as two or more origin exchanges, and API errors counted as origin errors. The README says that GitHub metadata lookups are not counted.The metadata request now uses
metrics.WithoutArtifactRequest. The 429 backoff scope stays on the context, so a rate-limited API call still pauses the strategy. GitHub API calls are still counted ingithub.api_calls.The README now also says that OCI registry ping and token exchanges are counted as origin traffic.
🤖 Generated with Claude Code