Repository navigation
fix: keep mirrors available during upstream cooldowns - #444
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1c2a3-3b00-7292-bb00-b4a066f5cd6b Co-authored-by: Amp <amp@ampcode.com>
worstell
marked this pull request as ready for review
November 10, 2026 00:07
worstell
requested review from
stuartwdouglas
and removed request for
a team
November 10, 2026 00:07
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80a636bc42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
alecthomas
approved these changes
Nov 10, 2026
Amp-Thread-ID: https://ampcode.com/threads/T-01a1c2a3-3b00-7292-bb00-b4a066f5cd6b Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1c2a3-3b00-7292-bb00-b4a066f5cd6b Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep healthy mirrors available when the primary returns HTTP 429. Share cooldowns by actual outbound hostname across strategies, schemes, and ports. Check each redirect destination independently, without blocking cache hits or other hostnames.
Preserve HTTP 429 and Retry-After from OCI registry authentication instead of returning 502. Mirror 404 and 5xx responses do not start a cooldown. Cooldowns remain process-local and apply to clients that use the shared HTTP transport.
Generated with Amp