Skip to content

IT: synchronous BmqBrokerSimulator - #131

Open
678098 wants to merge 1 commit into
bloomberg:mainfrom
678098:260901_synchronous_BmqBrokerSimulator
Open

IT: synchronous BmqBrokerSimulator#131
678098 wants to merge 1 commit into
bloomberg:mainfrom
678098:260901_synchronous_BmqBrokerSimulator

Conversation

@678098

@678098 678098 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fix the following IT errors:

[ERROR] Errors: 
[ERROR] com.bloomberg.bmq.it.BrokerSessionIT.sessionMustNotReconnectAfterStop
[ERROR]   Run 1: BrokerSessionIT.sessionMustNotReconnectAfterStop:411 » Runtime java.lang.IllegalStateException: Failed to acquire semaphore
[ERROR]   Run 2: BrokerSessionIT.sessionMustNotReconnectAfterStop:411 » Runtime java.lang.IllegalStateException: Failed to acquire semaphore
[ERROR]   Run 3: BrokerSessionIT.sessionMustNotReconnectAfterStop:411 » Runtime java.lang.IllegalStateException: Failed to acquire semaphore
[ERROR]   Run 4: BrokerSessionIT.sessionMustNotReconnectAfterStop:411 » Runtime java.lang.IllegalStateException: Failed to acquire semaphore

@678098
678098 force-pushed the 260901_synchronous_BmqBrokerSimulator branch 2 times, most recently from 114ed43 to 9045b91 Compare September 1, 2026 17:39
@678098 678098 changed the title IT[BmqBrokerSimulator]: synchronous stop IT: synchronous BmqBrokerSimulator Sep 1, 2026
@678098
678098 force-pushed the 260901_synchronous_BmqBrokerSimulator branch from 9045b91 to 3a79dca Compare September 2, 2026 16:42
@678098
IT: synchronous BmqBrokerSimulator
6e02190 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
678098 force-pushed the 260901_synchronous_BmqBrokerSimulator branch from 3a79dca to 6e02190 Compare September 10, 2026 19:02
@678098
678098 requested a review from a team as a code owner September 10, 2026 19:02
@678098
678098 requested a review from pniedzielski September 10, 2026 19:35
678098
678098 commented Sep 10, 2026
View reviewed changes
Comment thread bmq-sdk/src/test/java/com/bloomberg/bmq/it/util/BmqBrokerSimulator.java

@Override
public void start() {
thread = new Thread(this, "NettyTestTcpServer_thread");

@678098 678098 Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes this extra thread, and we don't need startSema anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pniedzielski pniedzielski Awaiting requested review from pniedzielski

At least 1 approving review is required to merge this pull request.

Assignees

@pniedzielski pniedzielski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@678098 @pniedzielski