Conversation
- Verify the peer certificate identity against the configured host, so a CA-signed certificate issued for a different host is no longer accepted. - Send SNI for named hosts; IP literals are sent without it per RFC 6066, and are verified against the certificate's iPAddress SAN instead. - Breaking: endpoints whose certificate omits the connect-time host name (notably IP endpoints without an IP SAN) now fail the handshake. Also allow the helloworld producer to connect over TLS. ConnectionString::parse rejects an amqps:// uri unless it is given SecurityParameters, so the producer example could only ever connect in plaintext. Take an optional certificate authority path as a second argument and build the SecurityParameters from it.
thisisnsh
marked this pull request as draft
September 17, 2026 15:30
thisisnsh
marked this pull request as ready for review
September 18, 2026 03:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview