Skip to content

[backport/1.4] Fix Ping discovery KeyError on disappearing interfaces - #4041

Closed
joaoantoniocardoso wants to merge 1 commit into
1.4-devfrom
backports/1.4/ping-interface-snapshot-race
Closed

[backport/1.4] Fix Ping discovery KeyError on disappearing interfaces#4041
joaoantoniocardoso wants to merge 1 commit into
1.4-devfrom
backports/1.4/ping-interface-snapshot-race

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Jul 27, 2026

Copy link
Copy Markdown
Member

This is a backport of #4036 into 1.4.

@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Backports #4036 into the 1.4 branch: list_ips() in core/services/ping/ping360_ethernet_prober.py now uses network_interface_addresses.get(interface, []) instead of direct indexing, avoiding a KeyError when an interface disappears between the psutil.net_if_stats() and psutil.net_if_addrs() snapshots. Adds regression tests covering the mismatched-snapshot case and the empty-snapshot case. Diff is byte-identical to the original PR aside from the pre-existing file-hash context.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@joaoantoniocardoso
joaoantoniocardoso force-pushed the backports/1.4/ping-interface-snapshot-race branch 2 times, most recently from bcee323 to a5098ec Compare July 28, 2026 15:02
@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

Superseded by #4058 (same changes, head moved to fork joaoantoniocardoso/BlueOS-docker).

@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

Closed in favor of #4058.

@joaoantoniocardoso
joaoantoniocardoso deleted the backports/1.4/ping-interface-snapshot-race branch July 28, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants