frontend: Fix MAVLink2Rest orphan WebSocket reconnects - #4044
Open
joaoantoniocardoso wants to merge 1 commit into
Open
frontend: Fix MAVLink2Rest orphan WebSocket reconnects#4044joaoantoniocardoso wants to merge 1 commit into
joaoantoniocardoso wants to merge 1 commit into
Conversation
3 tasks
Automated PR Review0. Summary
Fixes orphan WebSocket reconnects in No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
joaoantoniocardoso
requested review from
Williangalvani,
joaomariolago,
nicoschmdt and
patrickelectric
July 27, 2026 22:37
Disable reconnect on intentional close and close the previous send socket in setBaseUrl so probe/url changes cannot leave zombie sockets.
joaoantoniocardoso
force-pushed
the
pr/mavlink2rest-orphan-reconnect
branch
from
July 28, 2026 01:34
b4a39e2 to
cfb78ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oncloseso dying sockets cannot resurrect.setBaseUrlcloses the previous send socket before opening a new one (probe can call setBaseUrl more than once).Test plan
Supersedes #4030 (recreated from fork
joaoantoniocardoso/BlueOS-dockerinstead of same-repo head).