Skip to content

[backport/1.4] Fix bag-of-holding log spamming errors on normal operation - #4065

Merged
joaoantoniocardoso merged 2 commits into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/fix-bag-missing-key
Jul 30, 2026
Merged

[backport/1.4] Fix bag-of-holding log spamming errors on normal operation#4065
joaoantoniocardoso merged 2 commits into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/fix-bag-missing-key

Conversation

@joaoantoniocardoso

Copy link
Copy Markdown
Member

This is a backport of #4035 into 1.4.

@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Backport of #4035 into 1.4-dev. Stops GenericErrorHandlingRoute from stack-tracing every 4xx HTTPException (only logs exceptions for status >= 500), and fixes raise HTTPException(...) from KeyError in bag_of_holding to chain from the caught instance (from error) rather than the class. Together this silences the log spam that occurs on the routine GET /get/{path} 400 responses.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@joaoantoniocardoso
joaoantoniocardoso merged commit 6772e0e into bluerobotics:1.4-dev Jul 30, 2026
8 checks passed
@joaoantoniocardoso
joaoantoniocardoso deleted the backports/1.4/fix-bag-missing-key branch July 30, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants