Repository navigation
fix(gaming): return review fields from the admin game search - #291
Merged
Merged
Conversation
The backoffice game search declared the public game schema as its output, so oRPC stripped reviewStatus, reviewedAt and createdAt from results the service already returned. It now declares the admin game schema like the list route.
okapitula
requested review from
damianrzepka,
jakubfilinger-b,
klaudia-blazyczek-blurify,
marek-chmielowski-blurify,
mp-blurify and
zaxovaiko
as code owners
October 9, 2026 19:50
zaxovaiko
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /backoffice/gaming/games/searchnow outputspaginated(AdminGameSchema), the same item shape aslistAdminGames,updateGameandreviewGame.Why
The route declared
paginated(GameSchema), so oRPC strippedreviewStatus,reviewedAtandcreatedAtfrom each result even thoughlistGamesAdminalready maps rows throughtoAdminGame. A backoffice page that searches games and shows their review state could not type against the response. Only the contract changes; the service and query already return these fields.Risks
None. The response gains three fields and loses none.