Repository navigation
fix(chart): kates-platform points Kates at the Kafka it installs, in any namespace - #440
Merged
Merged
Conversation
bmscomp
force-pushed
the
fix/platform-kafka-namespace
branch
2 times, most recently
from
October 21, 2026 14:58
4d0a3ac to
d13da8c
Compare
…any namespace
The umbrella installs kafka-cluster in its release namespace, but the kates
subchart kept its own defaults: bootstrap servers and the Trogdor
coordinator in namespace kafka, and NetworkPolicy egress to namespace kafka
only. The platform profile admitted Kates to the brokers only from
namespace kates. Installed in kates, as the README does, Kates looked up
krafter-kafka-bootstrap.kafka.svc; installed in kafka, the brokers refused
it. No namespace worked.
kates 0.11.7 renders kafka.bootstrapServers, kafka.topicNamespace,
trogdor.coordinatorUrl and networkPolicy.kafka.namespace with tpl, and
kates-platform 0.8.1 sets them from {{ .Release.Namespace }}, as kates
deploy sets them with --set. It also overrides the profile's kates client
grant to the release namespace. The kates-backend KafkaUser, and so its
SCRAM Secret, was already in the release namespace with Kates.
The umbrella's Helm test pod now carries kates.io/test-pod=true, the label
kafka-cluster's broker NetworkPolicy admits test pods by; without it
helm test could not reach Kafka.
CI renders the umbrella in namespace platform and checks the bootstrap,
the Kates egress and the broker grant. Two MCP caveat refs into
charts/kates/values.yaml move by the two comment lines added there.
bmscomp
force-pushed
the
fix/platform-kafka-namespace
branch
from
October 21, 2026 15:23
d13da8c to
53c56e9
Compare
bmscomp
added a commit
that referenced
this pull request
Oct 21, 2026
Conflicts: the chart version (0.12.0 stays, above #440's 0.11.7), the version tables, and the CLI caveat refs into charts/kates/values.yaml, re-pointed to 408-418 and 618-686. #440 renders networkPolicy.kafka.namespace through tpl, so kates-platform can pass {{ .Release.Namespace }}; the Kafka-namespace Role and KATES_TOPOLOGY_KAFKA_NAMESPACE now use the same tpl, and the chart CI step checks a templated namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on #438 (kates-platform 0.8.0, now on main): this bumps it to 0.8.1.
Problem
kates-platform installs Kafka (
krafter) in its release namespace, but the kates subchart kept its own defaults, and the platform profile has its own grant:kates.kafka.bootstrapServerskrafter-kafka-bootstrap.kafka.svc:9092kafkakates.trogdor.coordinatorUrl…trogdor-coordinator.kafka.svc:8889kates.networkPolicy.kafka.namespacekafkakafkakates.kafka.topicNamespace""(backend falls back tokafka)kafkaplatform, clientkateskateskatesInstalled with
-n katesas the README does, Kates resolved…kafka.svcand its egress went tokafka. Installed with-n kafka, the brokers refused it. No namespace worked.The
kates-backendKafkaUser, and so the SCRAM Secret Strimzi writes, was already in the release namespace with Kates, so that part was fine.Fix
kafka.bootstrapServers,kafka.topicNamespace,trogdor.coordinatorUrlandnetworkPolicy.kafka.namespacego throughtpl. A value without{{renders as before, sokates deploy(which--sets these) and every plain install are unchanged.{{ .Release.Namespace }}, and overrides the profile'skatesclient tonamespace: ""(the release namespace). Kates floor>=0.11.7.kates.io/test-pod: "true", the label kafka-cluster's broker policy admits test pods by. Without it,helm testcouldn't reach Kafka.platformand checks the bootstrap, the Kates egress and the broker grant.charts/kates/values.yamlmove by the two comment lines added there.Proof
helm template p charts/kates-platform -n <ns>forkates,platformandkafka:Before (#438's head,
-n kates): bootstrap…kafka.svc, egress"kafka".The new CI step passes on this branch and fails on each of three regressions: dropping the client override (
kafka-cluster.networkPolicy.clients=null), the old bootstrap, and egress tokafka.Local checks
gen-chart-table.sh --check,gen-version-matrix.sh --check,check-versions.shactionlint,yamllint -c .yamllint.yaml .github config chartsgo vet ./cmd && go test ./cmdin cli/, includingTestMCPCaveatRefAnchorsNot in this PR
kates.chaos.kafka.namespaceandkates.topology.kafka-namespacedefault tokafka, and neither the chart norkates deploysets them. So in the umbrella outsidekafka, chaos targets, topology, cluster alerts and conformity still look inkafka.kafkatoo.