fix(find-injection): less noise (shell=True arg lists, bare SQL(), CSP in tests) - #58
Merged
Merged
Conversation
…-weakened in tests; bump to 0.28.0 Co-Authored-By: Claude Code <noreply@anthropic.com>
… in Python sinks Co-Authored-By: Claude Code <noreply@anthropic.com>
…ame:i} identifier) Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subprocess.*([...], shell=True)with a list/tuple whose program (first item) is a literal is no longer reported; later items are arguments, not shell code. A non-literal program or a string command is still an error.SQL(...)/Identifier(...)/Composed(...)(from psycopg.sql import SQL) is trusted likesql.SQL(...).csp-weakenedis no longer reported for test files, like every other rule.psycopg.sqlare always an option.a if c else b, loop over a literal tuple all count). Parameters,+=, any non-constant rebinding,globalrebinding and class-body names defeat it.Test plan
SQL, and test-file CSP🤖 Generated with Claude Code