ci(setup-bo4e): retry the CLI download on transient network errors - #1146
Open
lord-haffi wants to merge 1 commit into
Open
lord-haffi wants to merge 1 commit into
lord-haffi wants to merge 1 commit into
Conversation
The Check Docs job on #1142 failed with curl: (35) Recv failure: Connection reset by peer while fetching the bo4e CLI tarball. Nothing was wrong with the change under test -- a single TCP reset against objects.githubusercontent.com is enough to fail the whole docs build, for any PR. --retry-all-errors is needed alongside --retry because a bare --retry only covers transient HTTP responses and timeouts, not connection-level failures like this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
Check Docsjob on #1142 failed with:while fetching the bo4e CLI tarball in the
Install bo4e CLIstep. Nothing was wrong with the change under test — a re-run of the identical commit went green.A single TCP reset against
objects.githubusercontent.comis enough to fail the whole docs build, and it can hit any PR at any time, since.github/actions/setup-bo4eis used by every workflow that builds docs.What
Adds
--retry 3 --retry-delay 2 --retry-all-errorsto thecurlcall.--retry-all-errorsis required alongside--retry: a bare--retryonly covers transient HTTP responses and timeouts, not connection-level failures like the one observed.Verification
check-yaml/end-of-file-fixer/trailing-whitespacepre-commit hooks pass on the changed file.curlinvocation was run against the pinnedv1.3.0asset and downloaded it successfully (2023592 bytes).