Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions json_logging/framework/fastapi/implementation.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,14 @@ def get_method(self, request: starlette.requests.Request):
return request.method

def get_remote_ip(self, request: starlette.requests.Request):
return request.client.host
if request.client is not None:
return request.client.host
return json_logging.EMPTY_VALUE

def get_remote_port(self, request: starlette.requests.Request):
return request.client.port
if request.client is not None:
return request.client.port
return json_logging.EMPTY_VALUE


class FastAPIResponseInfoExtractor(BaseResponseInfoExtractor):
Expand Down
19 changes: 19 additions & 0 deletions tests/test_fastapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,3 +215,22 @@ def test_excluded_from_request_instrumentation(client_and_log_handler):

assert response.status_code == 200
assert len(handler.messages) == 0


def test_request_info_extractor_handles_missing_client():
"""Test if missing request client information falls back to empty values"""
import json_logging
from json_logging.framework.fastapi.implementation import FastAPIRequestInfoExtractor

request = fastapi.Request({
"type": "http",
"method": "GET",
"path": "/",
"headers": [],
"query_string": b"",
"client": None,
})
extractor = FastAPIRequestInfoExtractor()

assert extractor.get_remote_ip(request) == json_logging.EMPTY_VALUE
assert extractor.get_remote_port(request) == json_logging.EMPTY_VALUE
Loading