docs: add NOTICE copyright file#117
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughA new ChangesNOTICE file and distribution wiring
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds a new NOTICE file containing copyright information, updates MANIFEST.in to include it, and configures setup.cfg to package both LICENSE and NOTICE files. I have no feedback to provide as the changes are straightforward and correct.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
PR Summary by QodoAdd NOTICE file and include it in packaging metadata Description
Diagram
High-Level Assessment
Files changed (3)
|
There was a problem hiding this comment.
Auto Pull Request Review from LlamaPReview
Review Status: Automated Review Skipped
Dear contributor,
Thank you for your Pull Request. LlamaPReview has analyzed your changes and determined that this PR does not require an automated code review.
Analysis Result:
PR contains only documentation updates (adding a NOTICE file) and configuration changes (updating MANIFEST.in and setup.cfg), requiring no automated code review
We're continuously improving our PR analysis capabilities. Have thoughts on when and how LlamaPReview should perform automated reviews? Share your insights in our GitHub Discussions.
Best regards,
LlamaPReview Team
|
thanks for you contribution |
|
@bobbui Hello, this doesn't feel right to accept AI contributions like this. The Lines 190 to 202 in ac68fce |
Summary
NOTICEfile with a project copyright notice for json-logging-python.NOTICEinMANIFEST.inso source distributions ship it.setup.cfglicense metadata so bothLICENSEandNOTICEare treated as license files.Fixes #93
Verification
python setup.py check -m -spython setup.py sdist --dist-dir /tmp/json-logging-python-sdisttar -tzf /tmp/json-logging-python-sdist/json_logging-1.5.1.tar.gz | grep '/NOTICE$'\n-python -m pytest --ignore tests/smoketests\n\n## Notes\n- The copyright year is based on the first commit year referenced in the issue and confirmed from git history.Summary by CodeRabbit