Skip to content

ci(benchmark): only run for source-affecting changes - #127

Merged
natemoo-re merged 2 commits into
mainfrom
ci/benchmark-source-only
Sep 9, 2026
Merged

ci(benchmark): only run for source-affecting changes#127
natemoo-re merged 2 commits into
mainfrom
ci/benchmark-source-only

Conversation

@natemoo-re

@natemoo-re natemoo-re commented Sep 4, 2026

Copy link
Copy Markdown
Member

CI benchmarks are currently triggered on every PR.

This PR adds specific path filters to our workflows so that docs/CI-only changes skip the benchmarks and build. Direct source code changes, dependency updates, and tooling changes still run.

@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tty@127

commit: e8a208e

@natemoo-re
natemoo-re marked this pull request as ready for review September 4, 2026 22:26

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 😄

@gameroman

Copy link
Copy Markdown
Member

How will we make sure that this won't accidentally diverge from the codebase in the future?

@natemoo-re

natemoo-re commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@gameroman good question! do you know of any tools that can validate github action paths? i don't and usually rely on staying vigilant (which is unfortunately error-prone)

regardless, think this is a net improvement and we can track that as a follow-up here

@natemoo-re
natemoo-re merged commit a2ff425 into main Sep 9, 2026
9 checks passed
@natemoo-re
natemoo-re deleted the ci/benchmark-source-only branch September 9, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants