Skip to content

refactor: simplify element bounds lookup expressions - #163

Closed
cowboyd wants to merge 1 commit into
cleanup/renderer-directive-constantsfrom
cleanup/metadata-lookup-expressions
Closed

cowboyd wants to merge 1 commit into
cleanup/renderer-directive-constantsfrom
cleanup/metadata-lookup-expressions

Conversation

@cowboyd

@cowboyd cowboyd commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Simplify getElementBounds() by inlining the temporary TextEncoder and using a one-line early return when the element is missing. Lookup behavior and memory layout stay unchanged.

Stacked on #162; this PR targets cleanup/renderer-directive-constants and adds only the metadata lookup cleanup. No separate issue is needed for this mechanical refactor.

Validation: all 29 test suites (385 steps), deno task fmt:check, and deno lint pass. Ran deno task fmt; no additional formatting changes were needed.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (deno task test)
  • Files are formatted (deno task fmt)
  • I have added/updated tests for my changes (not applicable: existing coverage exercises unchanged behavior)
  • I have added a changeset (not applicable: internal cleanup with no user-facing change)

AI-generated code disclosure

  • This PR includes AI-generated code

@bombshell-cooper

Copy link
Copy Markdown
Contributor

No changeset needed

This pull request is classified as no_release_impact: no published package

@github-actions

Copy link
Copy Markdown

Size Reduced — -0.0 KB

129.4 KB unpacked

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tty@163

commit: 8fc2ebe

@cowboyd cowboyd closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant