Skip to content

Fix speaking and DAVE handling in the voice pacer - #3

Merged
appujet merged 6 commits into
mainfrom
fix/connection-hardening
Oct 17, 2026
Merged

appujet merged 6 commits into
mainfrom
fix/connection-hardening

Conversation

@appujet

@appujet appujet commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes audio being cut off or glitched at track ends and on join/reconnect.

Changes

  • Don't send the speaking-stop (empty mask op 5) when audio ends. It can cut off the tail of a track.
  • Hold audio until the DAVE key ratchet is ready, and send silence meanwhile. Audio could previously go out unencrypted.
  • Re-announce speaking on op 4 (SESSION_DESCRIPTION).
  • Announce speaking only after a successful send.
  • Drop zero-length frames instead of sending them.

Tests

Added unit tests for each change. cargo fmt, clippy and test pass.

Manual testing

  • Track end has no cut-off or pop
  • Join and reconnect with DAVE is glitch-free

@appujet
appujet merged commit caecf6e into main Oct 17, 2026
1 check passed
@appujet
appujet deleted the fix/connection-hardening branch October 17, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant