perf(formatters): hoist SCP git URL regex to package level in IsValidGitURL#446
Merged
SUSTAPLE117 merged 1 commit intoJul 3, 2026
Conversation
…GitURL Move regexp.MustCompile for SCP-style git URLs out of IsValidGitURL so the pattern is compiled once at init instead of on every call. Signed-off-by: Matías Insaurralde <matias@insaurral.de>
Contributor
|
Thanks @matiasinsaurralde LGTM |
SUSTAPLE117
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user@host:repo) from insideIsValidGitURLto a package-levelvar, so it is compiled once at init instead of on every call.ssh://, or SCP URL validation.Benchmark
BenchmarkIsValidGitURLon Apple M4 Pro (darwin/arm64), 10 runs each:The win is entirely on the SCP path (
git@github.com:user/repo), which previously calledregexp.MustCompileon every invocation.