Add scanner - #6640
Open
vishalparmarr wants to merge 9 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a repository-local “scanner” script intended to grep for common PII patterns (credit cards, SSNs, phone numbers), alongside several new/updated data and markdown files.
Changes:
- Implement
scripts/scan.shto scan the repo for PII-like patterns. - Add/update customer and partner list artifacts under
customers/andorgs/. - Add
slander.mdwith “Breaking News” content.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| slander.md | Adds a “Breaking News” markdown file (currently contains inappropriate personal/disparaging content). |
| scripts/scan.sh | Introduces a grep-based scanner for credit card, SSN, and phone patterns. |
| orgs/partners.txt | Appends a partner entry. |
| customers/favs.md | Adds a short “Favorite Customers” markdown list. |
| customers/banned.csv | Adds a banned customers CSV list. |
| customers/all.csv | Normalizes the header line formatting. |
Suppressed comments (2)
scripts/scan.sh:6
- Same issue here: \b is not a word-boundary in grep -E, so the SSN scan will typically never match.
grep -rE --color=always '\b[0-9]{3}-[0-9]{2}-[0-9]{4}\b' . --exclude-dir={.git} --line-number
scripts/scan.sh:11
- These phone-number scans also use \b with grep -E, so they will usually never match. Consider using digit-boundary guards instead (and keep the same --exclude-dir fix).
grep -rE --color=always '\b[0-9]{3}-[0-9]{3}-[0-9]{4}\b' . --exclude-dir={.git} --line-number
grep -rE --color=always '\([0-9]{3}\) [0-9]{3}-[0-9]{4}' . --exclude-dir={.git} --line-number
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1 +1,12 @@ | |||
| # TODO: write the script | |||
| printf "\n====== SCANNING FOR CREDIT CARD NUMBERS ======\n" | |||
| @@ -1 +1,12 @@ | |||
| # TODO: write the script | |||
| printf "\n====== SCANNING FOR CREDIT CARD NUMBERS ======\n" | |||
| grep -rE --color=always '(\b[0-9]{4}[- ]?){3}[0-9]{4}\b' . --exclude-dir={.git} --line-number | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.