Skip to content

Add scanner - #6640

Open
vishalparmarr wants to merge 9 commits into
bootdotdev:mainfrom
vishalparmarr:add_scanner
Open

Add scanner#6640
vishalparmarr wants to merge 9 commits into
bootdotdev:mainfrom
vishalparmarr:add_scanner

Conversation

@vishalparmarr

Copy link
Copy Markdown

No description provided.

Copilot AI lite review requested due to automatic review settings August 10, 2026 03:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a repository-local “scanner” script intended to grep for common PII patterns (credit cards, SSNs, phone numbers), alongside several new/updated data and markdown files.

Changes:

  • Implement scripts/scan.sh to scan the repo for PII-like patterns.
  • Add/update customer and partner list artifacts under customers/ and orgs/.
  • Add slander.md with “Breaking News” content.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
slander.md Adds a “Breaking News” markdown file (currently contains inappropriate personal/disparaging content).
scripts/scan.sh Introduces a grep-based scanner for credit card, SSN, and phone patterns.
orgs/partners.txt Appends a partner entry.
customers/favs.md Adds a short “Favorite Customers” markdown list.
customers/banned.csv Adds a banned customers CSV list.
customers/all.csv Normalizes the header line formatting.
Suppressed comments (2)

scripts/scan.sh:6

  • Same issue here: \b is not a word-boundary in grep -E, so the SSN scan will typically never match.
grep -rE --color=always '\b[0-9]{3}-[0-9]{2}-[0-9]{4}\b' . --exclude-dir={.git} --line-number

scripts/scan.sh:11

  • These phone-number scans also use \b with grep -E, so they will usually never match. Consider using digit-boundary guards instead (and keep the same --exclude-dir fix).
grep -rE --color=always '\b[0-9]{3}-[0-9]{3}-[0-9]{4}\b' . --exclude-dir={.git} --line-number
grep -rE --color=always '\([0-9]{3}\) [0-9]{3}-[0-9]{4}' . --exclude-dir={.git} --line-number

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/scan.sh
@@ -1 +1,12 @@
# TODO: write the script
printf "\n====== SCANNING FOR CREDIT CARD NUMBERS ======\n"
Comment thread scripts/scan.sh
@@ -1 +1,12 @@
# TODO: write the script
printf "\n====== SCANNING FOR CREDIT CARD NUMBERS ======\n"
grep -rE --color=always '(\b[0-9]{4}[- ]?){3}[0-9]{4}\b' . --exclude-dir={.git} --line-number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants