drop OBJ_VERSION_NO_HEADER_AAD (pack object format v1) support, fixes #9973 - #10362
Open
ThomasWaldmann wants to merge 1 commit into
Open
drop OBJ_VERSION_NO_HEADER_AAD (pack object format v1) support, fixes #9973#10362ThomasWaldmann wants to merge 1 commit into
ThomasWaldmann wants to merge 1 commit into
Conversation
…orgbackup#9973 Format version 0x01 was only ever written by borg 2.0.0b22 (before that there were no packs, b23 and later write 0x02). We don't owe compatibility across betas, so parse()/parse_meta() now accept only OBJ_VERSION_HEADER_AAD. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10362 +/- ##
==========================================
+ Coverage 87.93% 88.04% +0.11%
==========================================
Files 103 103
Lines 18893 18912 +19
Branches 2917 2919 +2
==========================================
+ Hits 16613 16651 +38
+ Misses 1583 1569 -14
+ Partials 697 692 -5 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9973.
RepoObj.parse()/parse_meta()accepted two pack object format versions:OBJ_VERSION_NO_HEADER_AAD(0x01, only ever written by 2.0.0b22) andOBJ_VERSION_HEADER_AAD(0x02, whatformat()writes since b23). We don't owe compatibility across betas, so the 0x01 fallback is gone before rc1:repoobj.py:OBJ_VERSION_NO_HEADER_AADremoved,SUPPORTED_OBJ_VERSIONSis now(OBJ_VERSION_HEADER_AAD,), the version-dependent AAD selection inparse()/parse_meta()is gone (header AAD + slot tag always). Comments and theobject_validatordocstring updated accordingly.repoobj_test.py:test_version1_object_without_header_aad_still_readableremoved.docs/internals/packs.rst: the 0x01 paragraph and the "0x01 still readable" table entry removed.A 0x01 object now fails with
unsupported object version: 1(the existing version check), same as any other unknown version.Full test suite passes locally (one unrelated
TestTimeoutTimertiming flake under-n auto, passes alone).🤖 Generated with Claude Code