Skip to content

benchmark tests: extract into an empty directory, fixes #10057 regression #10395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasWaldmann merged 1 commit into from
Sep 19, 2026
+8 −1
Merged

benchmark tests: extract into an empty directory, fixes #10057 regression #10395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/borg/testsuite/benchmark_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
py.test --benchmark-only
"""

import itertools
import os

import pytest
Expand Down Expand Up @@ -81,8 +82,14 @@ def test_create_lz4(benchmark, cmd_fixture, repo, testdata):

def test_extract(benchmark, cmd_fixture, repo_archive, tmpdir):
repo, archive = repo_archive
counter = itertools.count()

def setup():
# extract refuses a non-empty directory, so give each round a fresh empty one, see #10057
os.chdir(str(tmpdir.mkdir(f"extract{next(counter)}")))

with changedir(str(tmpdir)):
result, out = benchmark.pedantic(cmd_fixture, (f"--repo={repo}", "extract", archive))
result, out = benchmark.pedantic(cmd_fixture, (f"--repo={repo}", "extract", archive), setup=setup)
assert result == 0


Expand Down
Loading