chore(deps): bump ioredis to 5.11.1 via override (dedupe bullmq's pin)#197
Merged
Conversation
Lands the ioredis 5.10.1 -> 5.11.1 bump (#192) that was deferred from #190/#196. bullmq 5.78.0 exact-pins ioredis@5.10.1, so bumping the top-level dep alone left bullmq on its own nested 5.10.1 copy — two ioredis instances with structurally incompatible RedisOptions types (tsc failed on new Redis(options)). Adds an `ioredis: 5.11.1` override in apps/api that collapses bullmq's nested copy onto the top-level version. A clean `bun install --frozen-lockfile` (the CI condition) now resolves a single ioredis@5.11.1; 5.10.1 -> 5.11.1 is a semver patch. Drop the override once bullmq advances its own ioredis pin. Verification (infra up): single ioredis copy after frozen install, api check (tsc + lint + lint:meta + knip) clean, full api suite 1188 pass / 0 fail including the Redis/BullMQ/valkey integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lands the
ioredis5.10.1 → 5.11.1 bump (Dependabot #192) that was deferred from #190/#196, by resolving the dependency-tree split that blocked it.Why it was blocked
bullmq5.78.0 exact-pinsioredis@5.10.1. Bumping only the top-level dep left bullmq on its own nested5.10.1copy — twoioredisinstances whoseRedisOptionstypes are structurally incompatible, sotscfailed on everynew Redis(options)call.Fix
Add an
ioredis: 5.11.1override inapps/apithat collapses bullmq's nested copy onto the top-level version.5.10.1 → 5.11.1is a semver patch; the override is documented in//overridesand should be dropped once bullmq advances its own pin.Verification (infra up)
bun install --frozen-lockfile(the CI condition) resolves a singleioredis@5.11.1— no nested copy.bun run check(tsc + eslint + lint:meta + knip) ✓bun run test→ 1188 pass / 0 fail, including the Redis/BullMQ/valkey integration tests.Supersedes #192.