Reduce duplication in Coordinates constructors#3372
Open
ZedThree wants to merge 13 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| readFromMesh(options, ""); | ||
| } | ||
|
|
||
| Coordinates::Coordinates(Mesh* mesh, Options* options, const CELL_LOC loc, |
Contributor
There was a problem hiding this comment.
warning: constructor does not initialize these fields: non_uniform [cppcoreguidelines-pro-type-member-init]
Coordinates::Coordinates(Mesh* mesh, Options* options, const CELL_LOC loc,
^
ZedThree
force-pushed
the
coordinates-split-ctor
branch
3 times, most recently
from
7aff4fe to
4a08cb3
Compare
ZedThree
force-pushed
the
coordinates-split-ctor
branch
2 times, most recently
from
a976e78 to
a3d0999
Compare
dschwoerer
requested changes
Jun 16, 2026
dschwoerer
left a comment
dschwoerer
left a comment
Contributor
There was a problem hiding this comment.
I would prefer to revert the last two commits, as it requires as reading the fields twice, so it is imho not that much cleaner then the old design.
Member
Author
|
It is a little annoying, but note that we don't actually read twice -- at worst, the data will be read on the first Mostly I am now determined that |
Member
Author
|
@dschwoerer I've reverted those commits |
ZedThree
force-pushed
the
coordinates-split-ctor
branch
from
0401baa to
78e8f0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a lot of duplicated complicated code in the
Coordinatesinitialisation, this attempts to reduce it. This should make the refactor in #2873 smaller and easier to review as well