Repository navigation
Keep provisional roots out of turn delivery barriers - #196
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 425c55e8f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
October 16, 2026 18:57
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 19, 2026
Stephen Belanger (Qard)
force-pushed
the
pipeline/09-routing-stage-handlers
branch
from
October 19, 2026 19:25
f7b9c20 to
a4ad11f
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/10-root-reporting
branch
from
October 19, 2026 19:35
c595e48 to
a9055bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A provisional root waiting for child work currently keeps the route's delivery boundary open, retaining acknowledgements for otherwise completed turn batches. Stage root candidates before publishing route deliveries so empty sessions remain hidden while completed turns can drain independently.
The small
Rootsstage retains candidates and releases their saved operations immediately before their first direct child. SQLite commits the candidate snapshot, ready SpanOps, and consumed event position atomically. Restart restores the original values and creation provenance; append/commit retries retain already prepared output. Route consumers, InputPort, and completion receipts remain unchanged. Direct sink/import deferral remains compatible.Regression coverage reproduces the previous pending flush for an empty session, then verifies successful flush, continued empty-session suppression, and original provenance when work arrives after restart. Additional tests cover unrelated turns alongside an unused root, root update ordering, atomic candidate/release failures, and publication retry without duplicate staging. Existing lifecycle fixtures now include actual work; correlation still resolves before reporting an empty child. Recreated observers replay staged root birth records, preserving session fallback after idle retirement without replaying defensive retirement updates as native closure. A regression reproduces the missing fallback and verifies repeated observer recreation.
Validation before rebase: locked all-feature Rust suite passes all 548 tests, with five normally ignored live-agent tests. Strict all-target/all-feature Clippy, formatting, and diff checks pass. All four provenance tests also pass after replacing the old expected-timeout deadline with the normal successful-flush deadline. Remote CI passes on Linux, macOS, and Windows at
c595e48(run 38951791151).Based on main at
c41676d, including merged #193.Rebased at
a9055bb: all three commits retain identical patches (git range-diff); diff checks pass. Tests are left to fresh CI as requested.