Skip to content

Keep provisional roots out of turn delivery barriers - #196

Merged
Stephen Belanger (Qard) merged 3 commits into
mainfrom
pipeline/10-root-reporting
Oct 20, 2026
Merged

Stephen Belanger (Qard) merged 3 commits into
mainfrom
pipeline/10-root-reporting

Conversation

@Qard

@Qard Stephen Belanger (Qard) commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

A provisional root waiting for child work currently keeps the route's delivery boundary open, retaining acknowledgements for otherwise completed turn batches. Stage root candidates before publishing route deliveries so empty sessions remain hidden while completed turns can drain independently.

The small Roots stage retains candidates and releases their saved operations immediately before their first direct child. SQLite commits the candidate snapshot, ready SpanOps, and consumed event position atomically. Restart restores the original values and creation provenance; append/commit retries retain already prepared output. Route consumers, InputPort, and completion receipts remain unchanged. Direct sink/import deferral remains compatible.

Regression coverage reproduces the previous pending flush for an empty session, then verifies successful flush, continued empty-session suppression, and original provenance when work arrives after restart. Additional tests cover unrelated turns alongside an unused root, root update ordering, atomic candidate/release failures, and publication retry without duplicate staging. Existing lifecycle fixtures now include actual work; correlation still resolves before reporting an empty child. Recreated observers replay staged root birth records, preserving session fallback after idle retirement without replaying defensive retirement updates as native closure. A regression reproduces the missing fallback and verifies repeated observer recreation.

Validation before rebase: locked all-feature Rust suite passes all 548 tests, with five normally ignored live-agent tests. Strict all-target/all-feature Clippy, formatting, and diff checks pass. All four provenance tests also pass after replacing the old expected-timeout deadline with the normal successful-flush deadline. Remote CI passes on Linux, macOS, and Windows at c595e48 (run 38951791151).

Based on main at c41676d, including merged #193.

Rebased at a9055bb: all three commits retain identical patches (git range-diff); diff checks pass. Tests are left to fresh CI as requested.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 425c55e8f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread bt-daemon/src/pipeline/translation.rs
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T18:54:34.092352Z 425c55e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Qard
Stephen Belanger (Qard) force-pushed the pipeline/09-routing-stage-handlers branch from f7b9c20 to a4ad11f Compare October 19, 2026 19:25
Base automatically changed from pipeline/09-routing-stage-handlers to main October 19, 2026 19:35
@Qard
Stephen Belanger (Qard) merged commit f2fed06 into main Oct 20, 2026
22 checks passed
@Qard
Stephen Belanger (Qard) deleted the pipeline/10-root-reporting branch October 20, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants