Repository navigation
Fix recovery diagnostics and resume held session delivery - #202
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bebbbcf59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
October 20, 2026 14:53
Stephen Belanger (Qard)
changed the title
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage failures during session admission were labeled as credential failures, failed handoffs after session retirement were only logged, and changing delivery settings after an HTTP 400 left the original subscription held. Preserve typed failure boundaries, retain failed established-session handoffs in pending recovery, and let later settings corrections resume matching held subscriptions.
Corrections apply only within the same source session, authentication selection, and destination. Existing subscription heads and backend bindings remain intact; healthy independent routes retain their settings. Corrected non-secret settings and their original capture position are persisted so startup replay cannot revert a newer correction. SpanOp journals upgrade to schema 5.
Regression coverage exercises doctor output for blocked storage paths and corrupt databases, automatic storage recovery before and after idle retirement without new native input, pinned linked routes during retries, real HTTP 400 recovery through event ingress, plugin-chain replacement, and restart ordering when a correction is saved before the held head completes.
Validation
cargo +1.99.0 test --manifest-path bt-daemon/Cargo.toml --all-features --locked: 557 passed, 5 ignored (real-agent tests).cargo +1.99.0 clippy --manifest-path bt-daemon/Cargo.toml --all-targets --all-features --locked -- -D warningscargo +1.99.0 fmt --manifest-path bt-daemon/Cargo.toml --checkgit diff --checkSchema 5 upgrades existing journals in place; older daemon revisions cannot open the upgraded schema. This PR changes the daemon only; updating the separate bt consumer's dependency pin remains separate work.