Repository navigation
Delegate tracing hooks through BRAINTRUST_BT_BIN - #208
Open
Stephen Belanger (Qard) wants to merge 2 commits into
Open
Stephen Belanger (Qard) wants to merge 2 commits into
Stephen Belanger (Qard) wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a54daad21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex hooks resolve
btfrom PATH, which can select a stale unmanaged installation when a mise pin is inactive outside a project. HonorBRAINTRUST_BT_BINat the start of hook dispatch, before reading stdin or loading settings, to delegate to an absolute CLI executable while leaving the marketplace hook definition unchanged.The dispatcher preserves arguments, standard streams, and exit status, recognizes its own canonical path, rejects relative/missing targets, and detects wrapper loops. Unix replaces the process; Windows waits for the selected executable without allocating a console. Delegation is scoped to the mounted
bt trace hookentry point; the standalone development frontend retains its existing adapter protocol.The PATH-resolved CLI still needs a one-time upgrade to a release containing this behavior. Codex must inherit the variable, and it should name the actual executable rather than a version-manager shim. No config-file setting is added.
Validation: all 286 Rust library tests passed, including subprocess coverage for raw stdin, arguments, both output streams, status 23, paths with spaces, self-selection, invalid targets, and loop prevention. All-target/all-feature Clippy with warnings denied and
git diff --checkpassed on macOS. The initial Windows CI job passed. The initial Unix CI jobs exposed re-entry through standalone Cursor test adapters; delegation is now scoped to the production mounted command, and all five Cursor pipeline tests pass locally. The corrected revision now passes CI on Linux, macOS, and Windows. The full all-feature Rust suite also passes locally.Delivery requires updating the embedding
btCLI's daemon dependency and releasing it; no Codex plugin release is needed for the runtime change.