Skip to content

test: Bump e2e test package versions#2218

Merged
Luca Forstner (lforst) merged 9 commits into
mainfrom
lforst/e2e-two-lane-scenarios
Jul 15, 2026
Merged

test: Bump e2e test package versions#2218
Luca Forstner (lforst) merged 9 commits into
mainfrom
lforst/e2e-two-lane-scenarios

Conversation

@lforst

Copy link
Copy Markdown
Member

No description provided.

Base automatically changed from lforst/e2e-bump-workflow to main July 13, 2026 15:13
@lforst

Luca Forstner (lforst) commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Abhijeet Prasad (@AbhiPrasad) Stephen Belanger (@Qard) I know this is a bit ridiculous to review. I honestly did not look at all the outputs myself. This is purely additive and adding/bumping versions, so we have more visibility. We just gotta make sure that the adjustments we did in the scenarios are sane.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust the process

@Qard Stephen Belanger (Qard) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have very little trust in any system which results in 200k line PRs. Nobody is going to review that fully, it would take days to do so. 😬

@lforst

Copy link
Copy Markdown
Member Author

I have very little trust in any system which results in 200k line PRs. Nobody is going to review that fully, it would take days to do so. 😬

Stephen Belanger (@Qard) what's your suggestion to proceed?

@Qard

Copy link
Copy Markdown
Collaborator

I won't block merging, because being up-to-date is better than not, I guess. But I definitely think we should rethink the value of this e2e set up. It's way too big to be able to update it with any confidence of correctness. At the least we should probably have a conversation about it at a future team sync to think about what we can do to refactor or replace this with something we can actually trust.

@lforst

Copy link
Copy Markdown
Member Author

I won't block merging, because being up-to-date is better than not, I guess. But I definitely think we should rethink the value of this e2e set up. It's way too big to be able to update it with any confidence of correctness. At the least we should probably have a conversation about it at a future team sync to think about what we can do to refactor or replace this with something we can actually trust.

sgtm! This is the best that I could come up with. Feel free to share any thoughts on what you think is optimal.

@lforst Luca Forstner (lforst) merged commit 8467697 into main Jul 15, 2026
48 checks passed
@lforst Luca Forstner (lforst) deleted the lforst/e2e-two-lane-scenarios branch July 15, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants