Repository navigation
fix(pydantic-ai): don't log deferred tool calls as errors - #975
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 19, 2026
Conversation
Tools raising CallDeferred or ApprovalRequired hand the call back to the caller as DeferredToolRequests. That is control flow, not a failure, but the tool span recorded it as an error. Catch both inside the span, log the deferral kind (and CallDeferred/ApprovalRequired metadata when present) on the span, and re-raise after the span closes. Fixes SDK-581 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Luca Forstner (lforst)
approved these changes
Oct 19, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/sdk-581-pydantic-ai-integration-deferred-tool-calls-incorrectly
branch
October 19, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/braintrustdata/issue/SDK-581
Supersedes #969 (thanks to Ethan Leifer (@ethanleifer) for the PR)
AI Summary
Pydantic AI tools that raise
CallDeferredorApprovalRequiredwere logged as failed tool spans, even though these exceptions are Pydantic AI's normal way to defer a call or request human approval. Real failures show up as errors on the tool span, so deferred calls were tripping monitoring and alerting.How this differs from #969
output={"deferred": True, "reason": "<ExceptionName>"}metadata.deferred(+deferred_metadata)ImportErrorfallbackmin_versionis1.10.0, which has both🤖 Generated with Claude Code