Repository navigation
Disable session upload progress - #349
Merged
Merged
Conversation
API Gateway and Lambda receive the whole request before PHP runs, so upload progress can never be tracked. Disabling it removes the attack surface of CVE-2026-115560, as recommended by PHP until the next release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
That's exactly the conclusion I came to when they announced it. So that's not needed, right? |
Contributor
|
I'd lean towards doing this anyway. If it's not supposed to be reachable, then we can view this as security hardening and not a problem to just turn off. |
Contributor
|
For what it's worth, I did this in my own PHP Lambda layers already. |
Contributor
Author
|
It was flagged in our latest security review, and I suspect many others will see the same too. I wouldn't say it's worth a release on its own, but just hardening of something that needant ever be a vector for Bref |
Member
|
Fair! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP published an advisory for CVE-2026-115560 (not fixed yet), which recommends
session.upload_progress.enabled=0until the next release.On Lambda the feature can't work anyway: API Gateway and Lambda receive the whole request before PHP runs, so PHP parses the upload in a few milliseconds, and with
session.upload_progress.cleanup=On(the default) the progress is removed from the session straight away. No request could ever read it, so disabling it shouldn't break anything.I added a check in
test_2_extensions.php. Tested inbref/arm-php-85:3.0.10andbref/php-84:3.0.10with the newbref.ini: the check fails with the current one and passes with this change. FPM picks it up too (php-fpm -i).🤖 Generated with Claude Code