Repository navigation
fix(pg-protocol): fail the stream when the parser throws on an unsupported message - #3843
Open
vtxe02023274 wants to merge 1 commit into
Open
vtxe02023274 wants to merge 1 commit into
vtxe02023274 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3842
When the server sends a message the parser cannot handle (for example AuthenticationGSS, code 7),
parseAuthenticationResponsethrows inside the socket'sdatalistener. Nothing catches it, so it becomes an uncaught exception and the process exits instead ofconnect()rejecting.parse()in pg-protocol now catches errors thrown by the parser and destroys the stream with that error.Connectionalready forwards stream errors, soconnect()rejects while connecting and queries fail with the error afterwards. Errors thrown by the caller's callback are not touched and still propagate.Tests: two cases in
inbound-parser.test.ts(parser error fails the stream, callback error still throws) andgh-issues/3842-tests.jswith a scripted server that answers the startup message with AuthenticationGSS. CI on my fork passes on all Node and PostgreSQL versions.