Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom value whose
toPostgres()returnsnullorundefinedworks as a scalar parameter, but throwsTypeError: Cannot read properties of null (reading 'replace')when used inside an array.The parameter-conversion documentation says array items are recursively converted using the same rules. Prepare each element once and emit unquoted SQL
NULLwhen the prepared value is nullish; other values keep their existing escaping.Regressions cover null/undefined returns, nested arrays, chained custom conversion, exactly-once conversion, and literal
NULL, empty-string, zero and false controls.Validation on Node 24.22.1 / Linux:
pgunit suite (make test-unit): 289 passing.git diff --check: pass.No live PostgreSQL, native libpq, Cloudflare worker, or full-monorepo integration run is claimed. The published patch is byte-for-byte identical to the tested patch on the unchanged upstream base.
Disclosure: Codex implemented and tested this change under the submitting account's authorization.