add -- args passing from shell as const args in query

[mccanne]

Closes #2223

[nwt]

Nit: Although this tests code in compiler/parser, it's more a test of the super command than the parser itself, so cmd/super/ztests feels like a more natural home.

[nwt]

Maybe do this without escape and unescape (which won't do the right thing in the unlikely event that one of the arguments is "\x00--")?

--- a/pkg/charm/instance.go
+++ b/pkg/charm/instance.go
@@ -3,6 +3,7 @@ package charm
 import (
        "flag"
        "fmt"
+       "slices"
        "sort"
        "strings"
 )
@@ -77,9 +78,15 @@ func parse(spec *Spec, args []string, parent Command, interiorLeaf int) (path, [
                }
                path = append(path, component)
                parent = cmd
-               if err := flags.Parse(escape(args)); err != nil {
+               savedArgs := args
+               var dashDashArgs []string
+               if k := slices.Index(args, "--"); k >= 0 {
+                       dashDashArgs = args[k:]
+                       args = args[:k]
+               }
+               if err := flags.Parse(args); err != nil {
                        if usage {
-                               s := strings.Join(args, " ")
+                               s := strings.Join(savedArgs, " ")
                                err = fmt.Errorf("at flag: %q: %w", s, err)
                        }
                        return path, nil, false, err
@@ -87,7 +94,7 @@ func parse(spec *Spec, args []string, parent Command, interiorLeaf int) (path, [
                if help {
                        return path, nil, hidden, NeedHelp
                }
-               rest := unescape(flags.Args())
+               rest := append(flags.Args(), dashDashArgs...)
                if len(rest) != 0 {
                        spec = component.spec.lookupSub(rest[0])
                        if spec != nil {

[mccanne]

cool