docs(security): Option A (uninstall pyarrow) probed and rejected — record why - #229
Merged
Merged
Conversation
…rom the Flink image Probed 2026-07-21 inside the real agentflow-flink-local image: after pip uninstall pyarrow, `import apache_beam` itself crashes — beam 2.61 io/__init__ star-imports parquetio, whose class bodies evaluate `pa.Table` annotations with pa=None (AttributeError). The transitive dependency is load-bearing at import time even though our DataStream jobs never use it, so "remove unused pyarrow" is not a viable way to drop the safety ignore. Comment only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DORA Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comment-only follow-up to #228. The external-review suggestion "eliminate the last safety ignore by uninstalling unused pyarrow from the Flink image" was probed in the real
agentflow-flink-localimage before touching any code, and it fails:beam 2.61 soft-imports pyarrow (
pa = Noneon failure) but its parquetio class bodies evaluatepa.Tableannotations at import time — so the whole beam package (which the PyFlink harness imports) is unimportable without pyarrow. The record goes into the ignore comment so the idea is not re-opened by a future session or audit.Probe context: image probes also confirmed the positive claims from the review — submit-side and beam-worker imports succeed with pyarrow present, and the import-attempt trace shows pyarrow is pulled in via
apache_beam.io.parquetio, not by any PyFlink DataStream path.Verification
yaml.safe_loadOK;tests/unit/test_security_workflow.pypasses.🤖 Generated with Claude Code