feat(browserstack-service): render end-of-build summary entries (SDK-7358) - #200
Open
shivam5643 wants to merge 2 commits into
Open
shivam5643 wants to merge 2 commits into
shivam5643 wants to merge 2 commits into
Conversation
…7358) The binary returns CustomerVisibleSummaryEntry items on StopBinSessionResponse for end-of-build messages such as the SDK version nudge. The service had neither the proto field nor a renderer, so those messages were dropped for every wdio customer running through the CLI path. Adds the proto field and a renderer that writes `body` verbatim, picks the stream from `severity` (warn/warning/error -> stderr, everything else including unknown -> stdout so a malformed severity cannot trip CI stderr watchers), and archives a copy to the log file for runners that keep only the log directory. Deliberately does not branch on `entry_type`, so future entry types need no further service change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Renders end-of-build customer-visible summary entries (SDK-7358).
The binary returns
CustomerVisibleSummaryEntryitems onStopBinSessionResponseforend-of-build messages such as the SDK version nudge. The service had neither the proto
field nor a renderer, so those messages arrived and were silently dropped for every wdio
customer running through the CLI path.
Adds the proto field and a renderer that writes
bodyverbatim, picks the stream fromseverity, and archives a copy to the log file. Deliberately does not branch onentryType, so future entry types need no further service change — matching node, java,python and ruby.
Stream choice:
warn/warning/error-> stderr, everything else including unknown ->stdout, so a malformed severity cannot false-alarm CI tooling watching stderr.
Worth noting for reviewers: only wdio-mocha (non-multiremote) reaches this path today, since
CLISupportedFrameworksis['mocha']and the classic path bypasses the binary entirely.Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
entries+CustomerVisibleSummaryEntrytosdk-messages.proto, matching the binary's canonical definition (field 5).GrpcClient.renderCustomerVisibleSummarywritesbodyverbatim (not through the logger, whose per-line prefix would break the binary's box-border alignment) and archives a copy viaBStackLoggerfor CI runners that keep only the log directory.stopBinSessionstill returns its response.Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
Testing
stopBinSessionpath; file passes 8/8.tscandeslintboth exit 0.v8branch.🤖 Generated with Claude Code