ci(sdk-pr-review-gate): green when the agent RAN on the latest commit, not only when it passes - #202
Merged
Merged
Conversation
…, not only when it passes Rolls out the "mandatory to run, not to pass" gate change (SDK-7256) — the same one-line change piloted and validated on browserstack-node-agent#2574. The `gate` required check now turns green as soon as the SDK PR Review Agent has posted a verdict marker for the PR's CURRENT head commit — ANY verdict (success | failure | pending) — instead of requiring state=success. The verdict is advisory; QA uses the green label to decide on merge. A new commit turns it red until the agent re-runs on that commit. Closes the RCA-1320 gap (a PR merging with no review at all) without the "endless comments / never goes green" friction. CI/workflow only — no runtime or package change; marker parsing, the ready-for-review label requirement, and the Slack/branch-protection wiring are untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
kamal-kaur04
approved these changes
Sep 16, 2026
anish353
approved these changes
Sep 16, 2026
shivam5643
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Rolls out the mandatory-to-run gate change (SDK-7256) — the
gatecheck now greens when the SDK PR Review Agent has run on the PR's latest commit (any verdict), not only when it passes; verdict advisory. Piloted on browserstack-node-agent#2574. CI/workflow only.Related Jira task/s
https://browserstack.atlassian.net/browse/SDK-7256
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
gaterequired check now turns green as soon as the SDK PR Review Agent has posted a verdict marker for the PR's current head commit (any verdict: success | failure | pending), instead of requiring state=success. Verdict is advisory; a new commit turns it red until the agent re-runs. Closes the RCA-1320 gap (PR merging with no review) without the never-goes-green friction. Same one-line change piloted on browserstack-node-agent#2574.Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.