skill: lock two-producer generator tables in plan tests - #869
Closed
btipling wants to merge 1 commit into
Closed
Conversation
create-plan / plan-review treated parse+clock rows as DoD for a blob another producer already writes. #864 / PR #868 then spent five adversarial CONCERNS rounds inventing suffix-merge one fixture at a time. Plans that read/write/merge/adopt a shared record must lock live reconstruction × the other producer's persist points before implement. N/A when a single producer owns the body.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-plan + plan-review now require a generator table when a plan reads/writes/merges/LWW-adopts a session, transcript, envelope, or blob that another live producer already writes.
--changedgreen on parse + clock + role-map is not DoD for that surface. Tests must instantiate this producer's live reconstruction × the other producer's persist points.Named miss: #864 / PR #868 — five adversarial CONCERNS rounds inventing suffix-merge one fixture at a time.
N/A — single producer with one line when nothing else writes that body.
Surfaces
.grok/skills/create-plan/SKILL.md(v1.2) + issue template.grok/skills/plan-review/SKILL.md(v1.2) + rubric.grok/skills/README.mdNo application code.
npm run buildN/A.