Skip to content

fix(core): keep ActionPanel submenu open when hovering into it #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kinged007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): keep ActionPanel submenu open when hovering into it #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 34 additions & 5 deletions packages/core/src/components/ActionPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
} from '@react-trace/ui-components'
import { useAtom, useAtomValue, useSetAtom } from 'jotai'
import type { ReactNode } from 'react'
import { useCallback } from 'react'
import { useCallback, useEffect, useRef, useState } from 'react'

import {
portalContainerAtom,
Expand Down Expand Up @@ -257,6 +257,8 @@ export function ActionPanel({ plugins }: ActionPanelProps) {
)
}

const SUBMENU_CLOSE_DELAY_MS = 150

function Submenu({
entryContent,
plugins,
Expand All @@ -268,15 +270,40 @@ function Submenu({
}) {
const portalContainer = useAtomValue(portalContainerAtom)
const setSelectedSource = useSetAtom(selectedSourceAtom)
const [open, setOpen] = useState(false)
const closeTimerRef = useRef<number | undefined>(undefined)

useEffect(() => {
return () => window.clearTimeout(closeTimerRef.current)
}, [])

const keepOpen = useCallback(() => {
window.clearTimeout(closeTimerRef.current)
setOpen(true)
setSelectedSource(source)
}, [source, setSelectedSource])

const scheduleClose = useCallback(() => {
window.clearTimeout(closeTimerRef.current)
closeTimerRef.current = window.setTimeout(() => setOpen(false), SUBMENU_CLOSE_DELAY_MS)
}, [])

return (
<DropdownMenu.Root
onOpenChange={(open) => open && setSelectedSource(source)}
open={open}
onOpenChange={(next) => {
setOpen(next)
if (next) {
window.clearTimeout(closeTimerRef.current)
setSelectedSource(source)
}
}}
>
<DropdownMenu.Trigger
openOnHover
delay={0}
closeDelay={0}
onMouseEnter={keepOpen}
onMouseLeave={scheduleClose}
onFocus={keepOpen}
onBlur={scheduleClose}
style={(state) => entryStyle(state.open)}
>
{entryContent}
Expand All @@ -301,6 +328,8 @@ function Submenu({
style={{ zIndex: 999999, pointerEvents: 'auto' }}
>
<DropdownMenu.Popup
onMouseEnter={keepOpen}
onMouseLeave={scheduleClose}
style={{
minWidth: 200,
paddingBlock: plugins.length > 0 ? 4 : 0,
Expand Down